search

EBI-Metabolights / SAFERnmr

4 stars 2 forks source link

some backfits are poorly aligned in plotting #34

Open judgemt opened 11 months ago

judgemt commented 11 months ago

error appears to be sporadic and not common, but noticable when zooming in. Strangely, the intensities of these fits appear correct, but they appear shifted.

judgemt commented 10 months ago

this was because the fit optimization result was not used to set spec.start and spec.end in backfit_rfs3(). This should now be fixed.

judgemt commented 10 months ago

lags did not match the fits

judgemt commented 10 months ago

e.g. we were supposed to get this:

image

but instead would get something like this:

image
judgemt commented 7 months ago

Just tested specific problematic fits again by re-running backfit_rfs3(), and the issue appears to be resolved. It is not in the fit reconstruction or plotting functions, nor does it have anything to do with matching (for these examples). see troubleshooting_fits.R push from today.