EBI-Metagenomics / emg-viral-pipeline

VIRify: detection of phages and eukaryotic viruses from metagenomic and metatranscriptomic assemblies
Apache License 2.0
118 stars 16 forks source link

Regression - VirSorter prophage report at the end of the contigs #93

Closed mberacochea closed 1 year ago

mberacochea commented 1 year ago

By updating the virsorter container to the one hosted in biocontainers we introduced a regression: https://github.com/simroux/VirSorter/issues/68. VirSorter extends the prophage sequence by 50 nucleotide beyond the last gene in 5' and 3' (to include potential att sites and not end a contig right on a start / stop codon). I just forgot to include a check to make sure we don't extend past the contig, i.e. if the last gene of the prophage is at the end of the contig, the coordinate from VirSorter will be 50 nucleotides beyond the contig (hence 63493 vs 63443).

mberacochea commented 1 year ago

Fixed by https://github.com/EBI-Metagenomics/emg-viral-pipeline/pull/94