search

EBISPOT / OLS

Ontology Lookup Service from SPOT at EBI
http://www.ebi.ac.uk/ols
Apache License 2.0
96 stars 40 forks source link

Ontology property description not showing #461

Closed hrshdhgd closed 3 years ago

hrshdhgd commented 3 years ago

I am new to configuring the OLS so pardon me if this is a naive question. I edited the ols-config.yaml to add a definition_property: to reflect skos:definition as shown below:

Screen Shot 2021-02-05 at 8 34 09 PM

Now after deployment when I search for a particular property outLWSpikeNAQM, it shows me the property information as shown below:

Screen Shot 2021-02-05 at 8 38 38 PM

But when I click on the item to visit the property page, the 'Property information' is blank. Am I missing something?

Screen Shot 2021-02-05 at 8 39 27 PM
henrietteharmse commented 3 years ago

Can you please provide a small minimal ontology and related configuration illustrating the problem? This will help us to investigate this further.

hrshdhgd commented 3 years ago

Sure, the owl file for the ontology could be found here and the config setup in the ols-config.yaml could be found here. Please let me know if you need anything else.

henrietteharmse commented 3 years ago

Can you please provide a minimal ontology illustrating the problem rather that the full ontology?

hrshdhgd commented 3 years ago

Sorry about that. Here's the minimal ontology. neon-min.owl.zip

jamesamcl commented 3 years ago

Hi, thanks for the example - this should be fixed now!

matentzn commented 3 years ago

Are you sure this is fixed? seems like nothing has been merged into master since December 8!

matentzn commented 3 years ago

Done now closing again! Thanks!

hrshdhgd commented 3 years ago

Hello,

The original issue seems to be fixed! Thank you for that.

I noticed another issue that the description shows up in the center of the page as shown below:

Screen Shot 2021-02-25 at 11 33 54 AM

But not in here along with property Information. Does that get it from somewhere else? If, so could you please direct me in the direction to make that happen?

Screen Shot 2021-02-25 at 11 38 34 AM

matentzn commented 3 years ago

what is the property used in you ontology for the definition? IAO:0000115?

hrshdhgd commented 3 years ago

No , it is SKOS definition (http://www.w3.org/2004/02/skos/core#definition)

matentzn commented 3 years ago

Thats probably why. @udp can you somehow configure the definition property in OLS

matentzn commented 3 years ago

@hrshdhgd try https://github.com/EBISPOT/OLS-Config/blob/310f76b0acd23d6ad8d2333afc506de517e228ba/ols-config-importer/ols-ontologies.yaml#L11

hrshdhgd commented 3 years ago

Here's my config:

Screen Shot 2021-02-25 at 5 19 24 PM

and here's the page: Screen Shot 2021-02-25 at 5 19 16 PM

No change.

matentzn commented 3 years ago

But didnt you just say that your definition_property is http://www.w3.org/2004/02/skos/core#definition? It still seems IAO_0000115..

hrshdhgd commented 3 years ago

I just changed it based on your recommendation in the link above.