Annotation overspills in UI + recognise hyperlinks

EBISPOT / OLS

Ontology Lookup Service from SPOT at EBI

http://www.ebi.ac.uk/ols

Apache License 2.0

96 stars 40 forks source link

Annotation overspills in UI + recognise hyperlinks #465

Open mcourtot opened 3 years ago

mcourtot commented 3 years ago

https://www.ebi.ac.uk/ols/ontologies/duo and attached screenshot Screenshot 2021-02-25 at 08 37 55

Bug: the links towards the GH contributors list overspills on the right of the ontology information box. Enhancement: it would be great if the link could also be recognised and rendered as an hyperlink.

mcourtot commented 3 years ago

Same is true at https://www.ebi.ac.uk/ols/ontologies/duo/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FDUO_0000007&viewMode=PreferredRoots&siblings=false for the "Term information" box

Screenshot 2021-02-25 at 08 42 50

henrietteharmse commented 3 years ago

The text that is overspilling is also an enhancement. The text areas are good at wrapping at the end of words. To try and resolve this, all text will need to be analysed to figure out whether there is by chance a long string that needs to be broken up artificially. This has performance implications. Hence, this is not something we can implement. Similarly figuring out whether arbitrary text contains hyperlinks will have performance implications.

For both these requests I will prefer having dedicated annotations that the community can agree on:

See Also: Which can only contain a list of hyperlinks
Contributors Links: Which can only contain a list of hyperlinks

henrietteharmse commented 3 years ago

Ah! Just had a chat with @zoependlington. Apparently http://www.w3.org/2000/01/rdf-schema#seeAlso is already used in EFO and Mondo.

matentzn commented 3 years ago

This is great. Now this would be amazing, if it could be done in the same wash: hasDbXref. This points to a curie sometimes (most often), which ols knows how to turn into an iri. Example:

Not necessary for this ticket, but would be awesome: could we make the orphanet and efo links clickable as well? Orphanet:536391 EFO:1001502

henrietteharmse commented 3 years ago

@matentzn Implementation wise that is a different issue because EFO:1001502 is not actually a link but needs to be looked up to find the link and then rendered as link. The problem is to do this lookup efficiently. Me and @udp have discussed this extensively last year without finding an easy way to add this into OLS.

matentzn commented 3 years ago

I thought The OLS api can do this! But yes different issue. Just wanted to chime in!

henrietteharmse commented 3 years ago

Yes, OLS indeed has an API call that can look up a single term. However, this is not efficient for use in this case as it will result in a sharp increase in the amount of traffic generated for each ontology term visited for each user. What we need here a cache with latency close to 0. Otherwise this will result in OLS pages load much slower.