EBISPOT / OLS

Ontology Lookup Service from SPOT at EBI
http://www.ebi.ac.uk/ols
Apache License 2.0
96 stars 40 forks source link

Missing type field on obo_synonym #614

Closed EliotRagueneau closed 2 years ago

EliotRagueneau commented 2 years ago

Hi, I'm a developer in IntAct team, and in our release pipeline, we use the obo_synonym type of this endpoint based on MI ontology. However, the type received is null.

The expected behaviour is the following: Source ontology file: Term definition

[Term]
id: MI:0000
name: molecular interaction
def: "Controlled vocabularies originally created for protein protein interactions, extended to other molecules interactions." [PMID:14755292]
subset: Drugable
subset: PSI-MI_slim
synonym: "mi" EXACT PSI-MI-short []

==> Term has a synonym mi of the type named PSI-MI-short

Source ontology file: Synonym types definitions

synonymtypedef: PSI-MI-short "Unique short label curated by PSI-MI" EXACT

==> type of obo_synonym of term MI:0000 should be "Unique short label curated by PSI-MI" as it is the definition of PSI-MI-short

The last time we ran our release pipeline, in January 2022, we didn't face this issue so this field was probably populated correctly then. This problem seems to also be present in the MOD ontology, since in this endpoint, the obo_synonym type should be "Short label curated by PSI-MOD"

serjoshua commented 2 years ago

Hi Eliot,

We already deployed our changes to production. Please let us know if any issue still exists. Kind regards.