EBISPOT / OLS

Ontology Lookup Service from SPOT at EBI
http://www.ebi.ac.uk/ols
Apache License 2.0
95 stars 40 forks source link

OBA preferred root node and show part_of hierarchy #653

Closed rays22 closed 1 year ago

rays22 commented 1 year ago

Based on feedback from some confused users who tried to navigate the Ontology of Biological Attributes (OBA) I am wondering if

There are several newer releases than the currently displayed OBA v2022-08-03, and it would be great to see the latest OBA release with the enhancements I am suggesting above.

matentzn commented 1 year ago

@rays22 the first (root node) will happen automatically at the next load. For the second, we need to edit the hierarchical properties in the OLS config. @serjoshua can you remind me where this is hosted?

serjoshua commented 1 year ago

Hello Nico and Ray!

Yes, we could handle configuration (overrides) besides what is in OBO Foundry. Those overrides could be found here. You could also see there examples of other configuration that some ontologies have, such as hierarchical_property, as mentioned. As for the data update, we will add OBA to our next data release mid-December. It would be better as well if we already have the configuration for the hierarchical_property before the release so it will be included in the update. Otherwise, we will keep you posted regarding the release. Regards.

Josh

matentzn commented 1 year ago

@rays22 will you deal with adding the part of as an hierarchical property?

rays22 commented 1 year ago

OK, I have added the following snippet to EBISPOT/OLS-Config/prod/ols-ontologies.yaml

## OBA override
  - id: oba
    hierarchical_property:
      - http://purl.obolibrary.org/obo/BFO_0000050

and created a PR https://github.com/EBISPOT/OLS-Config/pull/8 . @serjoshua, please, let me know , if anything is missing or if it is not what you need.

serjoshua commented 1 year ago

Good morning Ray, that is just exactly what we need. Thank you. We will keep you posted regarding the release. Re-opening this ticket until OBA has been updated in OLS.

rays22 commented 1 year ago

Thank you Josh.

jonquet commented 1 year ago

@serjoshua quick question: is there a list somewhere of all the properties that can be "overrided" ? Could be interesting candidates for extending MOD (metadata for ontologies)... we do already have in MOD a few metadata properties to describe the properties used to define objects...

serjoshua commented 1 year ago

Hello Clement,

That is actually a good question. I'm not an expert in ontologies, OWL standards and the like, but we have a documentation on how to add ontologies in OLS and in the spreadsheet/form that we provide there, we have five (5) property configurations that we accept:

I hope it helps. Regards.

jonquet commented 1 year ago

Thanks. Good we already have some matches:

We also have in MOD2

Can you clarify the meaning of hidden_property ? This is a bit similar to obseolete to me, but if this is a porperty that has only value in OLS UI to avoid displaying the property on the screen... then it does not belongs to MOD I believe (that the policy we took first time we review a bunch of ontology repositories (including OLS) when we did MOD1.4).

serjoshua commented 1 year ago

Thank you. That is a good observation. I actually just checked our code and it seems like we are not using it anymore or about to discontinue. Apologies if my earlier response confused you. So, it seems like we only have the other four properties properly supported as of the moment. Let me know if you have other questions. Regards.

rays22 commented 1 year ago

The preferred root node OBA:0000001 is displayed for OBA on OLS. Thank you @serjoshua !