EBISPOT / efo

Github repo for the Experimental Factor Ontology (EFO)
https://www.ebi.ac.uk/efo/
55 stars 13 forks source link

Obsolete EFO:0001058 sensory system disease? #636

Open paolaroncaglia opened 4 years ago

paolaroncaglia commented 4 years ago

@simonjupp @zoependlington @smnorthen @d0choa To make a long story short, while working on Open targets therapeutic areas, we had trouble with terms like 'disease of ear', 'nose disease', 'tongue disease' (and previously 'eye disease' too) being descendants of 'nervous system disease' via their common parent 'sensory system disease'. We consulted extensively with Mondo (they had the same issue) and Uberon, and ultimately Mondo resolved to obsolete 'sensory system disease' as they deemed it of little utility and all its children have other parents anyway. In the Open Targets slim/profile, we had to remove 'sensory system disease'. I am now proposing to obsolete 'sensory system disease' from EFO altogether. We'll have to revise placement of its (12) children, but they should be mostly fine, and we should take the chance to see if they can be given better parents based on their definitions. Any objections please? :-)

(Note, we'll be reminded after the Mondo release as the missing mapping will throw an error.)

zoependlington commented 4 years ago

@paolaroncaglia No objection from me, this sounds very sensible.

smnorthen commented 4 years ago

@paolaroncaglia fine with me too. No objections from Open Targets

zoependlington commented 4 years ago

Mapping to the Mondo term (now obsolete) has been removed from the mapping file.

paolaroncaglia commented 4 years ago

Following up on this ticket, I'll list below the subclasses of 'sensory system disease' that may need work.

Other children of 'sensory system disease' shouldn't need any work other than

(Note for self - the checklist above was last revised on 9/6/2020.)

paolaroncaglia commented 4 years ago

@zoependlington Edits left to do for this ticket depend on https://github.com/EBISPOT/efo/issues/645. I'll remove my assignment now, thanks.