EBISPOT / efo

Github repo for the Experimental Factor Ontology (EFO)
https://www.ebi.ac.uk/efo/
56 stars 13 forks source link

Add subclass to EFO_0003072 (SK-N-SH) #739

Closed bonitalam closed 4 years ago

bonitalam commented 4 years ago

We would like to request SK-N-SH (https://www.ebi.ac.uk/ols/ontologies/efo/terms?iri=http%3A%2F%2Fwww.ebi.ac.uk%2Fefo%2FEFO_0003072) to be a subclass of cancer cell line (EFO:0001639).

Cellosaurus has it listed as a cancer cell line.

https://web.expasy.org/cellosaurus/CVCL_0531

Thank you for your help!

paolaroncaglia commented 4 years ago

@bonitalam Thanks for pointing this out.

Note for self and @zoependlington : this issue is related to the known classification issue in the neoplasm/cancer branch (https://github.com/EBISPOT/efo/issues/353). SK-N-SH is a subclass of neuroblastoma cell line, but neuroblastoma cell line isn't a child or descendant of cancer cell line. The missing links are due to the disease terms themselves. We need to figure out if neuroblastoma should be linked to cancer or not (it should, based on https://en.wikipedia.org/wiki/Neuroblastoma), and/or if cancer cell line should be axiomatised to neoplasm rather than cancer. These are quick thoughts and may need more work. Once the classification issue are fixed, more terms may reason to be subclasses of 'cancer cell line'. (I moved this discussion to https://github.com/EBISPOT/efo/issues/353, so no action item here.)

@bonitalam For now, I will

paolaroncaglia commented 4 years ago

@bonitalam This is fixed now, and will be visible after the mid-April EFO release.

bonitalam commented 4 years ago

Great, thank you @paolaroncaglia!