EBISPOT / goci

GWAS Catalog Ontology and Curation Infrastructure
Apache License 2.0
26 stars 19 forks source link

Sumstats filetype for GCST90432154 is GWAS-SSF v1.0 but should be non-GWAS-SSF #1358

Open eks-ebi opened 1 week ago

eks-ebi commented 1 week ago

This summary statistics file is missing two mandatory columns: beta and _standarderror, so should not meet the GWAS-SSF format. I also pushed it through validation manually. I would therefore expect the file type to be non-GWAS-SSF, but it is unexpectedly showing as GWAS-SSF v1.0 in the yaml file.

Actions:

karatugo commented 3 days ago

fixed the file type in mongo

karatugo commented 3 days ago

expect the new metadata yaml in 2 days

karatugo commented 3 days ago

Discuss tomorrow in the meeting.

/gwas/deposition/api/v1/bypass-ss-validation - this endpoint sends payloads with forceValid=True and skipValidation=False. I wonder how they should affect file type detection. For example, should we set non-gwas-ssf when either is True? (currently only set non-gwas-ssf when skipValidation=True).

karatugo commented 2 days ago

deployed to sandbox

karatugo commented 2 days ago

test okay in sandbox

karatugo commented 2 days ago

deployed to prod