EBISPOT / goci

GWAS Catalog Ontology and Curation Infrastructure
Apache License 2.0
26 stars 19 forks source link

Yaml files needs to be updated for the PMID:38448586 (submission ID: 6564aefc53c4ef0001094614) #1379

Closed Santhi1901 closed 2 weeks ago

Santhi1901 commented 1 month ago

The traits in the UI are correct, but the yaml files still have old traits and need to be updated.

Total 233 studies.

karatugo commented 1 month ago

Accession IDs: 90301941--90302173

eks-ebi commented 1 month ago

@eks-ebi to test this once completed (Santhi will be on leave next week)

karatugo commented 1 month ago

Looks good except for this one: http://ftp.ebi.ac.uk/pub/databases/gwas/summary_statistics/GCST90301001-GCST90302000/GCST90301942/

karatugo commented 1 month ago

There was something wrong with the one above due to caching I believe. Now all looks good to me.

ljwh2 commented 1 month ago

@eks-ebi to verify

eks-ebi commented 1 month ago

@karatugo Thanks I can confirm that the trait is now correct in the YAML for this study: http://ftp.ebi.ac.uk/pub/databases/gwas/summary_statistics/GCST90301001-GCST90302000/GCST90301942/

eks-ebi commented 1 month ago

@Santhi1901 there is one problem remaining in the traits in the UI, which was spotted by user Martijn Zoodsma on gwas-info. I've looked into it and I'm pretty sure that there is just one study with an incorrect Reported trait and EFOs:

GCST90301976 currently has Reported trait Cholesteryl esters to total lipids ratio in IDL, should be Total cholesterol to total lipids ratio in IDL. And the EFOs are currently cholesteryl esters:total lipids ratio and intermediate density lipoprotein measurement, should be cholesterol:total lipids ratio and intermediate density lipoprotein measurement.

I haven't made the change myself because I'm not 100% sure that I understand how you did the reannotation, and I could have made a mistake. Could you please have a look when you get back and make sure this is the correct way to fix the issue?

Santhi1901 commented 1 month ago

corrected the trait+EFO for GCST90301976 and republished

sprintell commented 1 month ago

Hi @Santhi1901 could you please confirm if this ticket can be closed ? Thanks

Santhi1901 commented 1 month ago

it can be closed