search

EBISPOT / goci

GWAS Catalog Ontology and Curation Infrastructure
Apache License 2.0
26 stars 19 forks source link

Template import - Ancestry sample description not right for a sample row with multiple ancestry groups #326

Open earlEBI opened 3 years ago

earlEBI commented 3 years ago

On importing submission 5ff430640164810001aee32b with template https://app.zenhub.com/files/2995118/64c52655-d0be-4aa6-99e6-369e0f80bdc0/download

Screenshot 2021-01-06 at 09.36.55.png

sample description in Curation App appeared as:

Screenshot 2021-01-05 at 10.50.23.png

should be: Screenshot 2021-01-05 at 10.52.31.png

ljwh2 commented 3 years ago

as well as the issue with multiple ancestries, looks like there is a pipe in the discovery sample that shouldn't be there?? Can you please confirm? @earlEBI

earlEBI commented 3 years ago

No, it's okay, I think that's just my cursor! @ljwh2

earlEBI commented 3 years ago

Related issue, should the most specific ancestry descriptor not appear if there is more than one, @ljwh2 ? i.e., the submission template: Screenshot 2021-02-08 at 14.34.22.png

imported as:

Screenshot 2021-02-08 at 10.27.22.png

should be:

Screenshot 2021-02-08 at 14.41.07.png

ljwh2 commented 3 years ago

Agree, that's how our curation rules work. I think we need to specify in the documentation/column headers that multiple ancestries should be separated by a pipe to allow the script to read them properly.