EBISPOT / goci

GWAS Catalog Ontology and Curation Infrastructure
Apache License 2.0
26 stars 19 forks source link

Associations imported with null p-values - PMID 32929287 #615

Open earlEBI opened 2 years ago

earlEBI commented 2 years ago

For PMID '32929287', original author submission, 731 studies published, then unpublished via the backend to add associations. I reuploaded the submission template via the depocuration app with associations and received no metadata errors, only sumstats errors, as expected:

Screenshot 2022-02-14 at 08.47.20.png

This was pushed through by Sajo and imported by me.

On checking, I see the most significant snps have imported with null p-values:

Screenshot 2022-02-14 at 08.15.58.png

I suspect all p-values below about 1e-308 are affected. See submission template:

https://app.zenhub.com/files/2995118/e7ba0f14-9955-4394-b352-074f823adda6/download

For this publication, I will fix the p-values manually to allow DR to go ahead. But the issue should be looked into to avoid it reoccuring.

ljwh2 commented 2 years ago

@earlEBI do you know if you would have been able to publish with this error? Looks like the associations are approved?

earlEBI commented 2 years ago

@ljwh2 Yes, they approved, but I'm afraid I don't know if it would've let me publish. I didn't try.