EBISPOT / goci

GWAS Catalog Ontology and Curation Infrastructure
Apache License 2.0
26 stars 19 forks source link

Duplicate EFOs in Curation App #795

Open earlEBI opened 2 years ago

earlEBI commented 2 years ago

Screenshot 2022-07-19 at 15.01.57.png

EFO duplicates keep appearing on this page in the curation app: http://ves-ebi-e4-x.ebi.ac.uk:8080/gwas/curation/efotraits

I have already cleaned this up last week but they have reappeared. Again I have cleaned up as listed here https://app.zenhub.com/files/2995118/bc27da0f-3555-4c27-92a2-a78db601462d/download

However, where 'deleted' is listed, these changes don't seem to have been saved as when you search for the term, eg diacylglycerol 36:1 measurement, you can still see the duplicates in curation app.

For the terms where two different URIs existed, I deleted the newer term from the depocuration as well.

Otherwise, duplicates, eg. the obsolete MONDO term for Myopia, do not show in Depocuration app, but I think will still cause problems when importing studies with the EFO label myopia.

earlEBI commented 2 years ago

Please delete the following EFO from depocuration as I am uanble to because they say they're linked to studies. I changed the EFOs in Curation app:

Creatine measurement EFO_0021579 Inositol measurement EFO_0021606 Theobromine measurement EFO_0021673

ljwh2 commented 1 year ago

@earlEBI is this an outstanding issue?

earlEBI commented 1 year ago

Yes, although I now see the EFOs are currently linked to PMID 33634981. So I'll try and change them first.

earlEBI commented 1 year ago

Actually, the problem terms are not in the Catalog UI, so this does still need to be cleaned up by a developer.

So, for instance: If you search for "not in use" (which is what I added to the 3 redundant term labels") on the studies page of depocuration, you see three linked studies from PMID 33634981. GCST90129098 GCST90129130 GCST90129205

Screenshot 2023-05-16 at 19 11 05

But when you search for these GCSTs in the live UI, they are linked to different (correct) EFOs.