search

EBISPOT / gwas-curation-service

0 stars 0 forks source link

Depo-Curation - Functionality to prevent missing EFOs #234

Open sajo-ebi opened 1 month ago

sajo-ebi commented 1 month ago

We recently faced issue with Data release where DR failed due to missing EFO's for some studies . This was accidently missed in Depo Curation while editing Backman Submission to update some EFO's . Curators felt that the studies tab in Submission details page currently doesn't have search filter & it is difficult to navigate to the specific GCST scrolling through pages , Hence they need search filter on the studies page to allow them to update the study directly through UI without needing to do bulk upload for few studies in large submissions.

Also we have huge impact in data release if Efo's are missing , the Data release fails at Solr QC step & we have to start DR from scratch to fix the issue . To avoid this we must add validation in Depo CUration to not enable Allow import button unless EFO are added for all studies , this will save us enormous amount of time rerunning DR & optimize the process

ljwh2 commented 1 month ago

A third feature that would help to avoid this is to be able to download currently assigned trait & EFO terms for a submission @earlEBI could you please add the details here, or are they covered by this ticket?

earlEBI commented 1 month ago

@ljwh2 I think it is covered there except to just double-check, will Mongo always match Oracle if the obsolete EFO script has auto-updated an EFO post-curation? Does the download have to specifically come from the live data?

ljwh2 commented 1 month ago

@earlEBI Sajo confirmed EFO update runs on Mongo only then it is synced with Oracle