This PR addresses the TypeError associated with the Float128 data type that Windows users encountered when running gwas-ssf without any options or files. The error was due to the lack of consistent support for the Float128 data type across platforms.
Changes
Introduced a platform check to conditionally set the p_value column data type to Float128 for non-Windows platforms and Float64 for Windows.
Updated the SumStatsSchema class in gwas_sumstats_tools/schema/data_table.py to reflect the above changes.
Testing
The changes were tested on both Windows and macOS platforms:
Test Steps:
Set up a fresh environment using Miniconda3 with Python 3.11.4.
Cloned the repository and checked out the 15-typeerror-dtype-float128 branch.
Installed the project dependencies using poetry install.
Ran the gwas-ssf command without options or files.
On both platforms, the previously reported error was not observed, confirming that the fix works as intended.
Summary
This PR addresses the
TypeErrorassociated with theFloat128data type that Windows users encountered when runninggwas-ssfwithout any options or files. The error was due to the lack of consistent support for theFloat128data type across platforms.Changes
p_valuecolumn data type toFloat128for non-Windows platforms andFloat64for Windows.SumStatsSchemaclass ingwas_sumstats_tools/schema/data_table.pyto reflect the above changes.Testing
The changes were tested on both Windows and macOS platforms:
Test Steps:
15-typeerror-dtype-float128branch.poetry install.gwas-ssfcommand without options or files.On both platforms, the previously reported error was not observed, confirming that the fix works as intended.
Resolves #15.