search

EBISPOT / gwas-ui

Apache License 2.0
5 stars 4 forks source link

Implement Gitlab CI/CD for deploying gwas-ui on the VM #210

Open sprintell opened 3 years ago

sajo-ebi commented 3 years ago

The Refactoring app has been deployed in Dev, Test & Preparation environment , getting some file read write access issues for Pro, Investigating the same

sajo-ebi commented 3 years ago

Have Deployed the refactored Search app in Prod , validating the application in Prod

sajo-ebi commented 3 years ago

validation of search ui done in Prod , it is working fine

sajo-ebi commented 3 years ago

@eks-ebi Below mentioned is the Refactored search Ui for validation

http://ves-pg-7e.ebi.ac.uk:9780/gwas/

eks-ebi commented 3 years ago

Tested 2021-10-15

In general the refactored UI works really well and maintains all of the features of the existing UI. Page loading times are also generally better than before.

Some issues identified:

  1. The link from this page (http://ves-pg-7e.ebi.ac.uk:9780/gwas/summary-statistics) to the API documentation fails. Instead of going to https://www.ebi.ac.uk/gwas/summary-statistics/docs/, it give a 404 Not Found error (http://ves-pg-7e.ebi.ac.uk:9780/gwas/summary-statistics/docs/)
  2. The link to Submit (http://ves-pg-7e.ebi.ac.uk:9780/gwas/deposition) also gives a 404. (I'm starting to suspect this is not a bug, but that this environment just doesn't include links to other services, so please ignore if that's the case)
  3. The Related Resources page (http://ves-pg-7e.ebi.ac.uk:9780/gwas/docs/related-resources) contains a weird bit of verbatim code at the top: <<<<<<< HEAD:src/main/docs/related-resources-content.adoc = Training & Related resources and bottom: >>>>>>> 9c652ea94260ab8048ec4eff240e1b98c317d0bf:goci-interfaces/goci-ui/src/main/docs/related-resources-content.adoc and other unformatted AsciiDoc content in the body of the page, e.g.

= Training & Related resources === GWAS Catalog training materials ==== EBI Train online

  1. The GWAS Diagram (http://ves-pg-7e.ebi.ac.uk:9780/gwas/diagram) does not display properly, instead shows a 404 error in the main window.
  2. Trait pages e.g. breast carcinoma (http://ves-pg-7e.ebi.ac.uk:9780/gwas/efotraits/EFO_0000305) do not correctly load the list of Mapped Terms Screenshot 2021-10-15 at 10.58.17.png Compare existing UI: Screenshot 2021-10-15 at 10.58.53.png
  3. Trait pages (example as above) are missing the PGS Catalog link: ![Screenshot 2021-10-15 at 11.00.52.png] (https://images.zenhubusercontent.com/5ebd0095cdca5a6323f696ae/23292679-66d7-4925-99ab-00852beaa589) Compare existing UI: Screenshot 2021-10-15 at 11.01.23.png
  4. Trait pages (example as above) missing @ala-ebi's new checkbox feature to include/exclude background traits data: Screenshot 2021-10-15 at 11.03.48.png Compare existing UI: Screenshot 2021-10-15 at 11.04.02.png
  5. Trait page (example as above) does not display the LocusZoom Plot
  6. Variant pages (e.g. http://ves-pg-7e.ebi.ac.uk:9780/gwas/variants/rs7329174) give a 500 Internal Server Error
  7. All Associations and Studies tables (any page e.g. http://ves-pg-7e.ebi.ac.uk:9780/gwas/genes/ELF1) are missing the Background trait(s) columns (probably related to point 7)
  8. Study pages (e.g. http://ves-pg-7e.ebi.ac.uk:9780/gwas/studies/GCST004633) are similarly missing the Background Trait(s) field: Screenshot 2021-10-15 at 11.10.41.png Compare existing UI: Screenshot 2021-10-15 at 11.11.34.png
  9. Blog link missing from top navigation bar: Screenshot 2021-10-15 at 11.13.59.png Compare existing UI: Screenshot 2021-10-15 at 11.14.17.png
  10. Banner that currently appears on the homepage is missing: Screenshot 2021-10-15 at 11.15.21.png Compare existing UI: Screenshot 2021-10-15 at 11.15.50.png
ljwh2 commented 2 years ago

what's the status of this please @sprintell? It's been in product backlog for a long time, can we complete it or put in icebox?