EBISPOT / gwas-user-requests

Repository to collect user requests and bug reports for the GWAS Catalog
3 stars 0 forks source link

Some studies are showing up in search, but are not loading #81

Closed DSuveges closed 10 months ago

DSuveges commented 11 months ago

Hi,

There's this study accession: GCST90271955 (also GCST90274714, GCST90277870, GCST90277997 etc)

If I search for it on the UI, I can see the study: image

However if you click, it won't load: image

I don't think if this was a browser or cache related issue, I managed to replicate it on different browsers. I assume this study is in pre-publication, that's why I could find the harmonised summary statistics on ftp (also the study is in the harmonised list on ftp), but not in the actual study index in the download files. Given until we have the complete metadata for a study, it is not possible to properly contextualise the contents of the summary statistics, is there a way to kind of "hide" these studies completely until curation?

Also somewhat related: looking at these studies, some are actually showing up in the study page with a pre-publication title. Looking at these titles, apparently some of them have already been published. I'm wondering if you are planning to prioritise these publications for curation?

Some examples:

ljwh2 commented 11 months ago

Thanks Daniel, we will investigate.

Given until we have the complete metadata for a study, it is not possible to properly contextualise the contents of the summary statistics, is there a way to kind of "hide" these studies completely until curation?

Would it help to have a column in the list of harmonised files saying whether it has been curated or not? We didn't used to harmonise prepublished files, but this was requested by other users.

DSuveges commented 11 months ago

We didn't used to harmonise prepublished files, but this was requested by other users.

That is a very strange request. What do they do with these summary statistics files if they don't know what is the trait or other metdata?

Would it help to have a column in the list of harmonised files saying whether it has been curated or not?

I'm not sure. Let's leave as it is given it was a user requests, we'll make our pipelines resilient for this.

ljwh2 commented 11 months ago

@DSuveges it's true there is no EFO term for the prepublished studies, but the reported trait is available, and all the mandatory study & sample metadata. After publication curators add the top associations and EFO (and any additional non-mandatory metadata mentioned in the paper).

DSuveges commented 11 months ago

You are right: I just realised there's a different file for studies with pre-published manuscripts... That's why I was not seeing any matching metdata because I was only looking at the gwas-catalog-download-studies-v1.0.3.1.txt table. However, I would still say it is quite strange that these studies show up on the search page, but their links to the study page doesn't work.

ljwh2 commented 11 months ago

Yes that's an error, we are investigating.

ljwh2 commented 11 months ago

For the prepub landing pages not loading intermittently, there is a separate ticket goci#1200.

For the submissions not inked to a PMID that you mentioned, one was assigned negative by our literature search and the others are in progress through the curation workflow. We picked up a few more where the PMIDs were never included in the literature search and we will follow up with LitSuggest developers to find out why. Thanks for flagging these.

Thanks for flagging these @DSuveges