EBISPOT / gwasdepo-deposition-service

0 stars 1 forks source link

Intermittent failure to make PUT request to sumstats service #161

Open jdhayhurst opened 2 years ago

jdhayhurst commented 2 years ago

After a successful sumstats submission, the backend issues GCSTs and makes a PUT request the sumstats service with a payload mapping the internal study ids with GCSTs. With this information the sumstats service can label the files with the GCSTs and set them up for publishing. Without the PUT call, the files will not be released. Occasionally, the call is not made, or at least not logged in the sumstats service. The last time this happened was with callback JxyvqoPA. This ticket is a for investigating why the PUT call doesn't always happen and fix it so that it always happens.

ljwh2 commented 2 years ago

How frequent would you say this is @jdhayhurst ?

jdhayhurst commented 2 years ago

perhaps every 4-8 weeks. Latest culprit is GCST90102284

ljwh2 commented 1 year ago

Still happening March 2023. Consider whether this can be communicated better to alert James to problem.

earlEBI commented 1 year ago

Another example: PMID 36402844. I moved these to staging manually.

eks-ebi commented 1 year ago

Another example for this submission: https://www.ebi.ac.uk/gwas/deposition/submission/6448f10a128651000158d3fe @earlEBI is manually adding these GCSTs on staging (GCST90268004 and GCST90268005) along with the parent folder (GCST90268001-GCST90269000) Note: in this case, there is also an error message about invalid sumstats that is still displaying in the submission UI, even though it was corrected and the sumstats passed validation the second time aroun - not sure if this could be related somehow

sajo-ebi commented 1 year ago

@ljwh2 looks like I have found the bug thanks to https://app.zenhub.com/workspaces/gwas-59df823c4a6feb3786810391/issues/gh/ebispot/goci/1172 , we had logs for this submission & could find the error due to which the Put request was not send to sumstats service , there is a scenario where there are two callbackids for the same submission because of invalid submission by user , this causes the PUt request in sumstats to fail