search

EBISPOT / hancestro

https://ebispot.github.io/hancestro/
Creative Commons Attribution 4.0 International
6 stars 2 forks source link

term disappeared? hancestro:0308 "has country of origin" #11

Closed ddooley closed 3 years ago

ddooley commented 4 years ago

I believe this was a term and id in ancestro, but has it been discontinued in hancestro? I'll fashion a FoodOn id for it if necessary.

daniwelter commented 4 years ago

Hmm, the term is definitely still in the source ontology. I will investigate what happened.

daniwelter commented 4 years ago

@ddooley Are you referring to the version of the ontology that's shown in OLS? If so, there's definitely something not quite right with it. If you look at the source ontology in the OBO foundry or on Github though, the term is still available.

ddooley commented 4 years ago

Indeed I was checking OLS. Apparently OLS had some ontology synchronization issues but not sure this has anything to do with that. Perhaps you could raise the missing term issue with them?

daniwelter commented 3 years ago

I have created a new release of HANCESTRO today and will check on the missing term issue in a couple of days, once the new version has been picked up by OLS.

daniwelter commented 3 years ago

@ddooley The term is still missing in OLS (but definitely in the ontology) so I've raised the matter again with the OLS team. I expect there will be a bit more movement on HANCESTRO in the next couple of months as it is now used by a number of other projects, so don't hesitate to flag issues or request new terms.

daniwelter commented 3 years ago

We now know the source of the issue, which is due to a hiccup in the ROBOT command used for generating the (default) inferred version of the ontology. Another release is planned for the first week of December, at which point this will definitely be fixed.

ddooley commented 3 years ago

Ok, good to know, thanks!

daniwelter commented 3 years ago

@ddooley The term is now visible again in OLS. Apologies it took so long to resolve this.

ddooley commented 3 years ago

I'm afraid it seems to have disappeared again? It only exists in OLS under FoodOn. It doesn't seem to resolve under its own URL: http://purl.obolibrary.org/obo/hancestro_0308

daniwelter commented 3 years ago

@ddooley I could be wrong but I think the OBO PURL resolver is case sensitive. http://purl.obolibrary.org/obo/HANCESTRO_0308 resolves fine for me.

ddooley commented 3 years ago

Ok, thanks for that point. And now I see that label for 0308 is "HasCountryOfOrigin" rather than "has country of origin", and that is why I wasn't finding it in OLS. Was that always the case?

daniwelter commented 3 years ago

Yes, I just double-checked v1.0 and property labels have always been single-word camel case. The only major change in terms of casing between v1 and v2 is the upper case purls and the rename from ANCESTRO to HANCESTRO as per request of the OBO foundry

ddooley commented 3 years ago

Ok, thanks! My bad!