EBISPOT / hancestro

https://ebispot.github.io/hancestro/
Creative Commons Attribution 4.0 International
6 stars 2 forks source link

unusual categorization: American is-a European #13

Closed cmungall closed 3 years ago

cmungall commented 4 years ago

https://www.ebi.ac.uk/ols/ontologies/hancestro/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FHANCESTRO_0463&viewMode=All&siblings=false

image

I get why you would add something like this, but I think you need to at least provide a bit more context for people, provide some kind of definition of what you mean by American and European, consider using different labels, and provide some high level documentation on your approach to categorization

daniwelter commented 4 years ago

Agreed, this looks odd. I could have sworn "American" was classed as an uncategorised population. I think the subclass of European should be "European American". I will check with the GWAS team and either move, update or clarify.

daniwelter commented 3 years ago

This issue has been addressed in today's release of HANCESTRO.