search

EBISPOT / ols4

Version 4 of the EMBL-EBI Ontology Lookup Service (OLS)
http://www.ebi.ac.uk/ols4/
Apache License 2.0
47 stars 22 forks source link

Hard code PHI and PECO ontology paths #658

Closed haideriqbal closed 6 months ago

haideriqbal commented 6 months ago

PECO ontology versions using import <owl:imports rdf:resource="http://purl.obolibrary.org/obo/peco/patterns/exposure-chebi_pattern.owl"/> are broken so have hard coded the version not using this import.

For PHI, have updated the path of obo file.

matentzn commented 6 months ago

Have you reported this to the respective ontology, like https://github.com/Planteome/plant-experimental-conditions-ontology/issues? Freezing ontologies this way does not seem like a sustainable solution..

Better solution would be to somehow put a huge banner on the page with the failing ontology say that the latest version cant loaded, with a link to the issue tracker for people to complain to the ontologies directly. You could choose, in addition to the banner, to dynamically load an old version (i.e. not updating the config and hardcoding the ontology path, but having some if.. else loading the latest version that did work)?

haideriqbal commented 6 months ago

@matentzn agreed it isn't a sustainable solution but this is an exceptional case to help a team within EBI to unblock their release.

The solution you mentioned of dynamically loading the ontology if the latest version fails is already in discussion among our team to optimise our data release pipeline.

matentzn commented 6 months ago

Great! Just make sure you report it on their issue trackers as well :)