search

EBISPOT / ols4

Version 4 of the EMBL-EBI Ontology Lookup Service (OLS)
http://www.ebi.ac.uk/ols4/
Apache License 2.0
38 stars 17 forks source link

Chemical Analysis Ontology short_form codes are incorrectly formatted #699

Closed stuchalk closed 1 week ago

stuchalk commented 1 month ago

Describe the bug The CAO ontology terms in OLS have incorrectly formatted short_form codes throughout.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://www.ebi.ac.uk/ols4/api/ontologies/cao/terms?lang=en
  2. Scroll down to any term
  3. Look at the contents of the short_form field

Expected behavior Go to the ontology at https://champ.stuchalk.domains.unf.edu/images/ontology/cao.owl and verify the term id format, 'CAO_\d{6}' in regex.

haideriqbal commented 1 month ago

Thanks for reporting @stuchalk! This doesn't look right and we'll look into it.

stuchalk commented 1 month ago

Thanks!

haideriqbal commented 2 weeks ago

This has been fixed in production now!

stuchalk commented 1 week ago

Thank you!

jamesamcl commented 1 week ago

They still look wrong to me?

  "short_form" : "CAO_CAO_000001",
  "obo_id" : "CAO_CAO:000001",
jamesamcl commented 1 week ago

Possibly related: https://github.com/EBISPOT/ols4/issues/721 ?

stuchalk commented 1 week ago

You are correct they are still wrong, and quite likely related to #721...

haideriqbal commented 1 week ago

Probably its a deployment issue let me check! it shows correct format on wwwdev

https://wwwdev.ebi.ac.uk/ols4/api/ontologies/cao/terms?lang=en

haideriqbal commented 1 week ago

The production system didn't have the latest config which resulted in this... in the next release cycle which will be tomorrow probably this will be fixed. I will keep an eye on it.

haideriqbal commented 1 week ago

I can see this fixed in production now! closing this.