EBISPOT / ols4

Version 4 of the EMBL-EBI Ontology Lookup Service (OLS)
http://www.ebi.ac.uk/ols4/
Apache License 2.0
47 stars 22 forks source link

Update exact synonym display on frontend #796

Closed haideriqbal closed 1 week ago

haideriqbal commented 1 week ago

solves this: https://github.com/EBISPOT/ols4/issues/368

haideriqbal commented 1 week ago

Awesome that this is being attacked! Good to see.

Is there a plan to add support for broad, narrow and related synonyms? Especially the latter has a lot of examples across ontologies!

@matentzn this change atm differentiate between exactMatch synonym and considers broad/narrow/related synonym as close match synonyms ... have a look at the below screenshot

Screenshot 2024-11-11 at 12 05 19

But if you want we can separate the related synonyms bit as well.. so on UI we can have something like:

exactSynonym -> ...... relatedSynonym -> ............. closestSynonym -> ................

matentzn commented 1 week ago

Why not go all on and separate them all as they are curated? Ontologies that make the effort to separate would certainly want to see exactly what they have curated? I am not concerned at all about a longer display, I think this information is very useful, and in fact, we have the opportunity here to have ontology developers separate more cleanly between these synonym types!

matentzn commented 1 week ago

(And as per naming, I would just use "Close synonyms", "Related synonym", "Broad synonyms" and "Narrow synonyms", I don't know where the "match" comes from in your display)..

Looks good though!

jamesamcl commented 1 week ago

I agree with @matentzn on both counts, and thanks @haideriqbal this is awesome!

haideriqbal commented 1 week ago

will make the necessary changes then. Thanks both

haideriqbal commented 1 week ago

Now synonyms will appear as they are curated in the ontology file.

Screenshot 2024-11-11 at 13 22 02

matentzn commented 1 week ago

Amazing @haideriqbal!!! Love it!

sabrinatoro commented 1 week ago

This is fantastic!!! Thank you @haideriqbal !!