EBISPOT / ols4

Version 4 of the EMBL-EBI Ontology Lookup Service (OLS)
http://www.ebi.ac.uk/ols4/
Apache License 2.0
47 stars 22 forks source link

Fix for pgatlas.com CORS issue for GWAS #802

Open haideriqbal opened 1 week ago

haideriqbal commented 1 week ago

This solves: https://github.com/EBISPOT/ols4/issues/801

We already allow requests from any origin, so technically, pgatlas.com shouldn't have an issue with CORS but we use * as allowed origin with credentials set as true so this might result in error on the browsers because of security issue. Hence, the reason pgatlas.com facing cors error. Further reading:

https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSNotSupportingCredentials https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin

Have tested it locally with different Origin domains using curl and seems to be working fine.