Closed apriltuesday closed 1 year ago
cc @ireneisdoomed @DSuveges @tskir for the example PharmGKB evidence string above... anything that should be changed just let me know (in particular field names - I've been reusing ones from ClinVar and making up some of my own with impunity).
@M-casado
How does having targetFromSourceId being the one mapped by PharmGKB and variantOverlappingGeneId from VEP affect the way we would interpret targetFromSourceId in evidence strings from ClinVar?
This is an excellent point and maybe something to put on the agenda for a subsequent meeting... I don't know if we'll be able change the ClinVar field names, but if not maybe we should name them differently here so they're consistent in the way you describe. (We should also check how well these two gene IDs are aligned across PGKB, it's always possible that we don't actually need both of them...)
@apriltuesday
This is an excellent point and maybe something to put on the agenda for a subsequent meeting... I don't know if we'll be able change the ClinVar field names, but if not maybe we should name them differently here so they're consistent in the way you describe. (We should also check how well these two gene IDs are aligned across PGKB, it's always possible that we don't actually need both of them...)
Agreed, I think maintaining the source of the keywords and finding a different name for them would make the future maintainer not pull their hair off if there is a time this gets curated.
I've linked to this in the meeting minutes, will merge this PR and make a subsequent one for any naming changes we decide on.
Closes #4, closes #6, closes #7
Example evidence string from tests:
Note
targetFromSourceId
is mapped from the gene provided by PharmGKB, whereasvariantOverlappingGeneId
is what we get from VEP based on the variant definition.