EBIvariation / trait-curation

A web application for manual curation of trait-to-ontology mappings, including provenance and integration with EBI SPOT stack.
Apache License 2.0
2 stars 2 forks source link

Design a page to display status & trigger external imports #32

Closed tskir closed 4 years ago

tskir commented 4 years ago

There are three external datasources which the app will communicate with:

This page will be essentially an extension of the "External datasources" page which you added in #39. Here are my thoughts on what we could include on that page:

tskir commented 4 years ago

Since this page seems handy to have, including for development/debugging purposes, I've raised the priority to high. I have also amended the description of this issue to include some things which can be added to this page.

joj0s commented 4 years ago

https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1 Here is a prototype of this page that I created. I haven't included development button such as "Import dummy data" or "Purge database" since this is supposed to be the production prototype, so I can add those at the top or bottom of the page.

tcezard commented 4 years ago

The prototype looks good I have a couple of comments:

joj0s commented 4 years ago

The section titles are not all placed the same way

Regarding this one, the idea is that 'TRAIT NAME SOURCES` is supposed to be a general section title, meaning that more trait name sources can be added later, besides ClinVar, as a list, beneath the 'TRAIT NAME SOURCES' section. I'm not sure if that makes sense? If not, let me know so I can clarify more on that.

Otherwise should I leave it as is, change it, or maybe I should add a similar title for the rest of the data sources, something like 'ONTOLOGY TERM SOURCES' ?

Besides that, the rest of the comments have been addressed and the prototype has been updated.

joj0s commented 4 years ago

I have gone through the changes mentioned in yesterday's call, feel free to take a look and tell me your thoughts: https://www.figma.com/file/pd5DHJSsldVtJcbp4RvkPb/GSoC-Trait-Mapping-App?node-id=0%3A1

joj0s commented 4 years ago

Also I can't seem to find an issue regarding the implementation of this page. I will go ahead an create one.

tskir commented 4 years ago

The mockup looks good to me! I'm going to close this issue, and you may go ahead and proceed with the implementation.