search

EBIvariation / trait-curation

A web application for manual curation of trait-to-ontology mappings, including provenance and integration with EBI SPOT stack.
Apache License 2.0
2 stars 2 forks source link

Suggestion of existing or new terms #63

Closed joj0s closed 4 years ago

joj0s commented 4 years ago

This PR is built on top of PR #62 and adds the ability to suggest new or existing terms. Closes #26, closes #27.

tskir commented 4 years ago

I've changed the base branch to "auth" (#62) for now, to remove redundant diffs and make the review easier. Before merging, I'll change this back to "master"

tskir commented 4 years ago

With this deployment, clicking on "Import all data" results in a timeout: image

This doesn't seem to happen in the deployment in #62, although it exhibits another problem with external datasources. I'm not sure whether the problems are related.

joj0s commented 4 years ago

With this deployment, clicking on "Import all data" results in a timeout.

That is because the Celery background worker isn't running in this deployment, so the problem in #62 is unrelated. You can verify it by checking this panel in the app's main Heroku page image

I have ran out of free Heroku apps I can have running, and subsequently Redis instances to deploy, so one thing I could do is have the two open PRs share a Redis database, and manually choose which worker we want to run, based on what app you want to review