search

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11
Apache License 2.0
130 stars 39 forks source link

clang 3.8 and 3.9 added #110

Closed InderKaur closed 6 years ago

InderKaur commented 6 years ago

New versions of clang are added to .travis.yml file. #105

jmmut commented 6 years ago

why both 3.8 and 3.9? each compiler we add makes the build slower, so we have to justify each addition. I didn't have time to check which version is used by default in newer linuxes and newer OSXs.

cyenyxe commented 6 years ago

Clang 4 and 5 are now supported in Travis, see https://github.com/travis-ci/apt-package-whitelist/pull/3297 and https://github.com/travis-ci/apt-package-whitelist/pull/4034

What I think we should do is to deprecate some of the oldest versions by checking what is the last Ubuntu LTS onwards, and add these more modern ones to the build. I would also keep at least one 3.x version.

InderKaur commented 6 years ago

I have done the requested changes. please have a look

cyenyxe commented 6 years ago

Any particular reason why you have left the oldest Clang 3.x version?

Anishka0107 commented 6 years ago

The latest version of clang I can see in ubuntu trusty is 3.9 (https://packages.ubuntu.com/trusty/devel/)

Maybe this could help you in installing clang 4.0 in trusty: https://superuser.com/questions/1280068/how-do-i-install-clang-4-0-on-ubuntu-14-04

See this too, for further information: https://apt.llvm.org

But I'm not sure, I'm not very familiar with Ubuntu.

cyenyxe commented 6 years ago

Closed due to lack of activity.