search

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11
Apache License 2.0
129 stars 39 forks source link

Adds log to display filename #116

Closed srbcheema1 closed 6 years ago

srbcheema1 commented 6 years ago

This PR is for the issue #115 I have added a message to display the filename of output file

srbcheema1 commented 6 years ago

@jmmut I have made the requested changes. Please have a look at it.

srbcheema1 commented 6 years ago

@jmmut I think there may be possibility that some error or exception is generated in try block before writing it to file. so thats why i was preffering not to print it in line 143. As it would be pointless to print it there if no file is written. tell me if I got something wrong.

jmmut commented 6 years ago

oh, my fault, the line std::string report_result = "... needs to be before the loop

jmmut commented 6 years ago

regarding the log placement, we are discussing it, we'll tell you later

jmmut commented 6 years ago

ok, after thinking about this, just move the line std::string report_result = "... line before the loop to make it compile and we'll merge this. In the future, if we have another report that doesn't write to a file we'll change the name of the method to something more generic, because it will be still useful.

srbcheema1 commented 6 years ago

@jmmut , should I undo the changes I did in last commit regarding these two lines(moving both the lines together). Or should I move only one line above the loop.

jmmut commented 6 years ago

only one line, we still want the last line to be the final yes/no statement.