search

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11
Apache License 2.0
129 stars 39 forks source link

Simplifying build for mac #136

Closed srbcheema1 closed 6 years ago

srbcheema1 commented 6 years ago

This PR aims to simplify build for mac OS X.

srbcheema1 commented 6 years ago

I will use this branch to test static and dynamic building in mac. As I will do changes I will keep pushing to this branch. Whenever it will be ready for review. I will ping you.

srbcheema1 commented 6 years ago

@cyenyxe @jmmut finally our build is passing on mac osx :) Please have a look and review.

srbcheema1 commented 6 years ago

@cyenyxe the build for mac is not purely dynamic. i have linked all the internal dependencies statically. i haven't yet worked on code polishing so there are stray lines and comments that i will remove and update the PR soon. should I update README.md accordingly ?

srbcheema1 commented 6 years ago

@cyenyxe @jmmut I have made the requested changes. Please review.

srbcheema1 commented 6 years ago

@cyenyxe @jmmut I have made the requested changes. Now our validator is ready with all the dependencies linked statically. The only dynamic dependencies remains are libc++ and libSystem. It is impossible to get rid of them as said in this link. All the technical part of the PR is complete. Please review the code :)

srbcheema1 commented 6 years ago

LGTM :) I am eager to see this merged :D What are your suggestions @jmmut