search

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11
Apache License 2.0
130 stars 39 forks source link

Resolved segmentation fault on an empty vcf file #155

Closed hritikgupta closed 6 years ago

hritikgupta commented 6 years ago

Added a condition for a check on the line size of the vcf file, which should not be less than 5 characters (which in turn gives a segmentation fault). as mentioned in the issue https://github.com/EBIvariation/vcf-validator/issues/154

hritikgupta commented 6 years ago

@srbcheema1 please review my PR for failed builds.

srbcheema1 commented 6 years ago

good work @hritikgupta :) Actually the tests failed due to the base you chose for while making the PR. you made the base to master which is far behind the develop branch. I have changed the base to develop, in the next commit the tests will pass. I am suggesting some changes after that you could make a new commit and add to the push it up. the tests will pass then.

srbcheema1 commented 6 years ago

@hritikgupta seems like you have deleted the fork. Now your PR is in broken state and there is no way out except closing this PR as per this issue Extremely sorry for it :disappointed:

hritikgupta commented 6 years ago

No worries @srbcheema1 . I'm new to OpenSource and GitHub, hence wasn't very much familiar with the work flow. Being my first PR to a project like this, it was a great learning experience contributing to it. Sincerely thankful to @srbcheema1 and @jmmut for guiding me and reviewing the PR.

srbcheema1 commented 6 years ago

@hritikgupta I have added your commit into the PR https://github.com/EBIvariation/vcf-validator/pull/156 your contribution will count :)