Clean assembly_checker - Githubissues

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11

Apache License 2.0

130 stars 39 forks source link

Clean assembly_checker #187

Closed iyangar closed 5 years ago

iyangar commented 5 years ago

moving internal functions to source file

iyangar commented 5 years ago

https://github.com/EBIvariation/vcf-validator/pull/187#pullrequestreview-240097523 Sure, i will move. ebi::vcf::default_line_buffer_size in validator.hpp and several other constants are in small? Let me know if i have to change here

jmmut commented 5 years ago

I can't see any other global constants in lower case, can you give an example? anyway I would only change default_line_buffer_size for now because it's better to reduce the number of files changed in each PR.