EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11
Apache License 2.0
129 stars 39 forks source link

mac build issue resolution #230

Closed vasudeva8 closed 5 months ago

vasudeva8 commented 6 months ago

Mac build failure, checked with Monterey - arm, reasons were

  1. libodb and libodb_sqlite packages having a file named "version", which is not a c/c++ file, gets included in build instead of the file "version" in c++ sdk include files due to include path specs. The version files are renamed during installation as version_odb and version_sqlite, that correct version file is included for build.

  2. packages brotli and ssl were old and did not support newer Mac platforms. These packages are updated to versions which support Mac arm 64bit as well. The min build platform for Mac is set as 12.0, to avoid warnings during build. Brotli package is built twice to get dynamic and static libraries, required for curl and vcf validator. (earlier version had both built as binaries with different name and new version have both static and dynamic output with same name). vcf-validator's CMakeFile.txt is also updated to work with new brotli output name.

Fixes #226