Simplify build for OS X users (docker based)

EBIvariation / vcf-validator

Validation suite for Variant Call Format (VCF) files, implemented using C++11

Apache License 2.0

129 stars 39 forks source link

Simplify build for OS X users (docker based) #82

Closed Anishka0107 closed 5 years ago

Anishka0107 commented 6 years ago

This PR aims to simplify the build for Mac (not supported as containerized os yet) users by providing a new Dockerfile which runs the tool inside of it. It is not convenient for developers though.

TODO: windows developers/users could use Docker Toolbox to get rid of the restriction of disabling virtualbox. (Fully supports docker, hence write new dockerfile with win base image)

jmmut commented 6 years ago

Can we write here what problems did we have? I honestly don't remember why we decided it was too hard to do the windows build, and couldn't make the mac one work.

cyenyxe commented 6 years ago

Running Docker on Windows requires to disable the native Windows virtualization, preventing software like VirtualBox from running.

In both operative systems people could run the binary using Docker Toolbox which doesn't have that issue, but the permissions it needs and the fact that the output is still a Linux binary make it nonviable for some environments; the second issue could be easy to solve though.

Having native, static builds would be the most user-friendly option if we can make it work.

cyenyxe commented 5 years ago

Fixed via https://github.com/EBIvariation/vcf-validator/pull/136.