EBSECan / donatemask

Donate A Mask Project Repository
GNU Lesser General Public License v2.1
10 stars 7 forks source link

Redesign donation form #115

Closed humphd closed 2 years ago

humphd commented 2 years ago

After the email outreach work @emmaelaine did last week, I've been talking with her about how to include some of what she found to be successful in the donation form. Having a more personal, direct message explanation of the goals seems to help a lot. Below is what I've done based on that, and how it looks, first on Desktop, then Mobile.

This change does the following:

NOTE: this builds on the stuff I've started to do for the back-end to add integration testing. That work is on-going, and we should NOT update the back-end yet. However, I don't want to block this front-end change, since I think it will help us improve donations.

Screen Shot 2022-05-22 at 9 07 56 PM Screen Shot 2022-05-22 at 9 08 18 PM Screen Shot 2022-05-22 at 9 08 46 PM Screen Shot 2022-05-22 at 9 09 06 PM Screen Shot 2022-05-22 at 9 09 21 PM Screen Shot 2022-05-22 at 9 09 40 PM
mekkim commented 2 years ago

This is SUPER AWESOME! I LOVE IT!

humphd commented 2 years ago

This is also ready to go. The failure is due to whatever caused the previous one to also fail (some random blip with the secret being injected). I'm going to merge this one too, and see what it does on main.

humphd commented 2 years ago

As predicted, passes on main: https://github.com/EBSECan/donatemask/runs/6573222302?check_suite_focus=true

I'm going to do a follow-up where the Stripe test, which needs secrets, only runs on main vs. in PRs.

humphd commented 2 years ago

@mekkim this, and the other recent changes are ready to be deployed.

You'll need to run npm install for both the front-end and back-end to get the modules they use, but everything else should be OK.

Let me know if you have any issues.