search

EC-CUBE / ec-cube2

EC-CUBE official repository version 2
https://www.ec-cube.net
Other
86 stars 97 forks source link

E2Eテストが頻繁に失敗するのを修正 #936

Closed nanasess closed 3 months ago

nanasess commented 3 months ago

購入フローのE2Eテストで 0 ポイントの会員が生成されると先に進めなくなる模様 https://github.com/EC-CUBE/ec-cube2/blob/master/e2e-tests/pages/shopping/payment.page.ts#L72-L75

eccube2-fixture-generator で会員を生成する際は、必ず1ポイント以上付与するよう修正

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.69%. Comparing base (8853c91) to head (079df26).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #936 +/- ## ======================================= Coverage 55.69% 55.69% ======================================= Files 75 75 Lines 8905 8905 ======================================= Hits 4960 4960 Misses 3945 3945 ``` | [Flag](https://app.codecov.io/gh/EC-CUBE/ec-cube2/pull/936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/EC-CUBE/ec-cube2/pull/936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE) | `55.69% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nanasess commented 3 months ago

MySQL8 の場合は data/config/config.php が生成される前にヘルスチェックが完了してしまうようなので、 data/config/config.php が生成されるまで待機するようにしました