search

EC-CUBE / ec-cube2

EC-CUBE official repository version 2
https://www.ec-cube.net
Other
86 stars 97 forks source link

Corepack を利用する #974

Closed nanasess closed 1 month ago

nanasess commented 1 month ago

Corepack を利用することで、 yarn のインストールされていない環境でも yarn コマンドを実行するだけで、 yarn をインストールすることができる https://yarnpkg.com/corepack https://zenn.dev/teppeis/articles/2021-05-corepack

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.63%. Comparing base (9b77175) to head (b3f106e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #974 +/- ## ======================================= Coverage 55.63% 55.63% ======================================= Files 75 75 Lines 8917 8917 ======================================= Hits 4961 4961 Misses 3956 3956 ``` | [Flag](https://app.codecov.io/gh/EC-CUBE/ec-cube2/pull/974/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE) | Coverage Δ | | |---|---|---| | [tests](https://app.codecov.io/gh/EC-CUBE/ec-cube2/pull/974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE) | `55.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EC-CUBE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nanasess commented 1 month ago

yarn v3 or v4 を利用するかどうかは要検討(ご意見ください)

nobuhiko commented 1 month ago

自分の環境ではyarnやめちゃいました

nanasess commented 1 month ago

@nobuhiko いまだと pnpm とかがいいんですかね？

nobuhiko commented 1 month ago

@nanasess 対して機能も使ってないしnpmでじゅうぶんなのかなーと思ってます。webpackは最近 exporse-loader を使ってちょっと最適化しました

nanasess commented 1 month ago

@nanasess なるほどー。たしかに webpack と playwright を実行するくらいしか使ってないので npm で十分かもですね