EC-CUBE / next-poc

Other
2 stars 4 forks source link

Symfony\Component\Routing\Exception\RouteNotFoundException #9

Closed chihiro-adachi closed 1 year ago

chihiro-adachi commented 1 year ago

概要(Overview・Refs Issue)

Symfony\Component\Routing\Exception\RouteNotFoundException をEccube例外でラップするように対応 AbstractControler::generateUrlで発生する例外をラップしています。

8

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

レビュワー確認項目

codecov-commenter commented 1 year ago

Codecov Report

Merging #9 (52593a3) into main (5d8b7cc) will decrease coverage by 0.02%. The diff coverage is 40.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main       #9      +/-   ##
============================================
- Coverage     80.27%   80.26%   -0.02%     
- Complexity     6575     6577       +2     
============================================
  Files           497      497              
  Lines         26547    26551       +4     
============================================
  Hits          21310    21310              
- Misses         5237     5241       +4     
Flag Coverage Δ
E2E 69.41% <40.00%> (-0.02%) :arrow_down:
Unit 77.50% <40.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Eccube/Controller/Admin/Store/PluginController.php 9.36% <0.00%> (ø)
...framework/Eccube/Controller/AbstractController.php 66.19% <50.00%> (-0.97%) :arrow_down:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.