search

EC-Nordbund / denomailer

A SMTP-Client implementation for deno (to send mails!)
https://deno.land/x/denomailer
MIT License
50 stars 16 forks source link

Support for Base64 attachments #26

Closed rdelpeso closed 2 years ago

rdelpeso commented 2 years ago

Fixes #25

Notes: No matter what I tried, I was never able to make the binary attachments work. So instead I added support for sending Base64 attachments. That works with GMail and Hotmail.

The core issue with binary attachments is that the Deno.Writer.write method (or something deeper in Rust) seems to be correction the binary "LF" and "CR" to "CRLF" always. I could not see any way to stop that from happening, so I gave up.

Let me know what you think of the code changes.

mathe42 commented 2 years ago

I added a test for \n / \r\n in https://github.com/EC-Nordbund/denomailer/blob/fix/binary-attachments/test/e2e/attachment.test.ts and will have a deeper look into it.

Deno.Writer is only a Interface so has no actual implementation so I will have to digg into it. I will hold #28 until I found the root cause for this.