search

EC-Nordbund / denomailer

A SMTP-Client implementation for deno (to send mails!)
https://deno.land/x/denomailer
MIT License
50 stars 16 forks source link

Added auto generated Content ID header support #27

Closed rdelpeso closed 2 years ago

rdelpeso commented 2 years ago

Usage:

await client.send({
  // Other items...
  html:
  'First image attachment <img src="cid:attachment_id_0"/> Second image attachment <img src="cid:attachment_id_1"/>',
});

In support of #25

rdelpeso commented 2 years ago

Waiting for #26 before proceeding with this one.

mathe42 commented 2 years ago

Looks good but I would add a option to the attachment object to set an ID as there might be use cases where you want to prepend your attachments allways with an extra attachment and then the IDs are not aligned.

So in the config add here https://github.com/EC-Nordbund/denomailer/blob/7da737e17c989695de9ec8788de66f8ed5889035/config/mail/attachments.ts#L3-L6

id?: string | number

mathe42 commented 2 years ago

I close this in favor of #28