search

EC-SEAL / interface-specs

Open API specifications
1 stars 4 forks source link

ApiClass values #1

Closed mvj66 closed 4 years ago

mvj66 commented 4 years ago

Feature Request

Hi @faragom

Describe the Feature Request Suggested values for the ApiClass type:

Is your feature request related to a problem? Please describe Just to complete the type definition since a first version of the CM has been uploaded.

Describe Preferred Solution

Additional Context See please ConfigManager.yaml

faragom commented 4 years ago

Ok. You have added those values to the file?

ec-esmo commented 4 years ago

I added those values to the ConfigManager.yaml tentatively, since I was waiting for your opinion and for other values.

ross-little commented 4 years ago

We need to conclude this now the name of the apiClass. Why don´t we just use the definition in the YAML of the base root of all the APIs:

i.e. /cl​/list​/{collection} = apiClass CL /sm/startSession = apiClass SM

Just one issue I see here for API GW SP and SP service both are using /sp/... which I think is not great. Better if the API GW to SP is using another root like /spgw/...

What you think?

mvj66 commented 4 years ago

I had defined the following apiClasses already (but I can change them):

faragom commented 4 years ago

It is better to keep the approach we did in ESMO, as Ross proposes: the first part of the api path is the apiClass (sp, per, etc.), the second is the api call.

changed the path of API GW SPfrom /sp/ to /spcl/

El mié., 18 dic. 2019 a las 11:09, mvj66 (notifications@github.com) escribió:

I had defined the following apiClasses already (but I can change them):

-

AUTHSOURCE // for eIDAS or eduGAIN

ATTRSOURCE // for eMRTD, eduGAIN, or eIDAS

SM

CM

APIGWCL // API Gateway Client

APIGWSP // API Gateway Service Provider

APIGWLK // API Gateway Linking

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EC-SEAL/interface-specs/issues/1?email_source=notifications&email_token=AG4HJ67UURQEKC7JY5Z3NF3QZHZG5A5CNFSM4JQCBJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHFTLVI#issuecomment-566965717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG4HJ63FOT244EGCHBZQ6GLQZHZG5ANCNFSM4JQCBJ4A .

-- Francisco José Aragó Monzonís mitsurugisan@gmail.com

mvj66 commented 4 years ago

OK

apiClassEnum: type: string enum: