search

ECALELFS / ECALELF

Code for electron calibration in CMS
http://ecalelfs.github.io/ECALELF/index.html
2 stars 22 forks source link

Higheta #21

Closed hengne closed 10 years ago

hengne commented 10 years ago

the first HighEta version need to put into the central version as a higheta branch.

shervin86 commented 10 years ago

the commits have been merged in one uniq commit in the higheta branch. I've revisited the ZNtupleDumper‎, please check it if it is fine. I'll fix the other files later. Da: Hengne Li Inviato: mercoledì 7 maggio 2014 17:41 A: ECALELFS/ECALELF Rispondi a: ECALELFS/ECALELF Oggetto: [ECALELF] Higheta (#21)

the first HighEta version need to put into the central version as a higheta branch.

You can merge this Pull Request by running

git pull https://github.com/hengne/ECALELF higheta

Or view, comment on, or merge it at:

https://github.com/ECALELFS/ECALELF/pull/21

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/ECALELFS/ECALELF/pull/21.

hengne commented 10 years ago

hello Shervin, thanks for taking care of my pull request.

Have you run any interactive test after your medication of the ZNtupleDumper?

Thanks, Hengne

On Sun, May 25, 2014 at 3:31 PM, shervin86 notifications@github.com wrote:

the commits have been merged in one uniq commit in the higheta branch. I've revisited the ZNtupleDumper‎, please check it if it is fine. I'll fix the other files later. Da: Hengne Li Inviato: mercoledì 7 maggio 2014 17:41 A: ECALELFS/ECALELF Rispondi a: ECALELFS/ECALELF Oggetto: [ECALELF] Higheta (#21)

the first HighEta version need to put into the central version as a higheta branch.

You can merge this Pull Request by running

git pull https://github.com/hengne/ECALELF higheta

Or view, comment on, or merge it at:

https://github.com/ECALELFS/ECALELF/pull/21

Commit Summary

  • test version for including highEta
  • test version for including highEta
  • add debuging
  • more prints
  • remove debug print outs
  • fixed a bug in electron and SC combination and selections
  • add options for High Eta SC
  • change email to Hengne.Li@cern.ch expecting to get the notice to Hengne s email address through out this test
  • scripts for interactive test of the HighEta production
  • added higheta options etc.
  • added higheta options etc.
  • added to also copy out the ntuples when doTree option is given
  • fixed the bug that shown in the last slide in Hengne's talk in the MoCa meeting 24 April 2014. It is a bug in the Mee calculation in selecting the HighEta SC.
  • fixed some bugs and tries to use the ZSCSkim Path to create the ntuple, but still the High Eta SC with sufficient enough PT are too small a fraction than expected ~10%
  • choose to use photons collection istead of SC collection, and add dedicated HighEtaSkim includes a selection of photons.
  • adding 13TeV option, and add the protection to use SLC5

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/ECALELFS/ECALELF/pull/21>.

— Reply to this email directly or view it on GitHubhttps://github.com/ECALELFS/ECALELF/pull/21#issuecomment-44133264 .

shervin86 commented 10 years ago

no, I've not finished yet, the code is not in a coherent state. please have a look at the diff and comment if there is something wrong. I've removed the photons since they can be biased by the photon hypothesis. any selection can be made before the dumper.

hengne commented 10 years ago

Hello Shervin,

Yes, I see that. Removing the Photons collection is fine as far as all the useful information I need can be re-calculated from SuperCluster. I think you will need to modify the skimming to adapt to this change to make it run properly.

Once you finish these and run some interactive test, I will take it from there to run some production test to do some validation of the physics plots such as the Mee. If further modifications needed I will make another pull request.

But before that, another thing is that I see you removed the "ZStat" branch which gives a flag of if-or-not a highEta Zee event. That's also fine, but I need to introduce a new flag for each electron to distinguish if it is one of the following type:

1.) in EB 2.) in EE with |Eta|<2.5 3.) in EE with |eta|>2.5 and getting from the SuperCluster 4.) anything else

I saw ( i.e. in the master branch) there is no such a variable to even distiguish an EB or EE electron.

Cheers, Hengne

On Sun, May 25, 2014 at 4:52 PM, shervin86 notifications@github.com wrote:

no, I've not finished yet, the code is not in a coherent state. please have a look at the diff and comment if there is something wrong. I've removed the photons since they can be biased by the photon hypothesis. any selection can be made before the dumper.

Da: Hengne Li Inviato: domenica 25 maggio 2014 16:48 A: ECALELFS/ECALELF Rispondi a: ECALELFS/ECALELF Cc: Shervin Nourbakhsh Oggetto: Re: [ECALELF] Higheta (#21)

hello Shervin, thanks for taking care of my pull request.

Have you run any interactive test after your medication of the ZNtupleDumper?

Thanks, Hengne

On Sun, May 25, 2014 at 3:31 PM, shervin86 notifications@github.com wrote:

the commits have been merged in one uniq commit in the higheta branch. I've revisited the ZNtupleDumper‎, please check it if it is fine. I'll fix the other files later. Da: Hengne Li Inviato: mercoledì 7 maggio 2014 17:41 A: ECALELFS/ECALELF Rispondi a: ECALELFS/ECALELF Oggetto: [ECALELF] Higheta (#21)

the first HighEta version need to put into the central version as a higheta branch.

You can merge this Pull Request by running

git pull https://github.com/hengne/ECALELF higheta

Or view, comment on, or merge it at:

https://github.com/ECALELFS/ECALELF/pull/21

Commit Summary

  • test version for including highEta
  • test version for including highEta
  • add debuging
  • more prints
  • remove debug print outs
  • fixed a bug in electron and SC combination and selections
  • add options for High Eta SC
  • change email to Hengne.Li@cern.ch expecting to get the notice to Hengne s email address through out this test
  • scripts for interactive test of the HighEta production
  • added higheta options etc.
  • added higheta options etc.
  • added to also copy out the ntuples when doTree option is given
  • fixed the bug that shown in the last slide in Hengne's talk in the MoCa meeting 24 April 2014. It is a bug in the Mee calculation in selecting the HighEta SC.
  • fixed some bugs and tries to use the ZSCSkim Path to create the ntuple, but still the High Eta SC with sufficient enough PT are too small a fraction than expected ~10%
  • choose to use photons collection istead of SC collection, and add dedicated HighEtaSkim includes a selection of photons.
  • adding 13TeV option, and add the protection to use SLC5

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/ECALELFS/ECALELF/pull/21>.

— Reply to this email directly or view it on GitHub< https://github.com/ECALELFS/ECALELF/pull/21#issuecomment-44133264> .

— Reply to this email directly or view it on GitHub< https://github.com/ECALELFS/ECALELF/pull/21#issuecomment-44135395>.

— Reply to this email directly or view it on GitHubhttps://github.com/ECALELFS/ECALELF/pull/21#issuecomment-44135736 .

shervin86 commented 10 years ago

Don't see where the CopyTree is used. Don't think it's needed.

hengne commented 10 years ago

That's a simple codes I wrote to separate Ntuples according to a user-defined selection string. Very handy.

but sorry, I must wrongly added it into that directory, it shouldn't belongs there, it should be part of my personal tools. Please remove it. Thanks.

On Sun, May 25, 2014 at 7:10 PM, shervin86 notifications@github.com wrote:

Don't see where the CopyTree is used. Don't think it's needed.

— Reply to this email directly or view it on GitHubhttps://github.com/ECALELFS/ECALELF/pull/21#issuecomment-44140084 .

shervin86 commented 10 years ago

I've updated branch higheta on ECALELF. I'll test it tomorrow