ECCC-MSC / libecbufr

libecbufr is a general purpose, template-oriented BUFR encoding/decoding library
Other
10 stars 7 forks source link

cgi should not be installed by default #54

Open vsouvan opened 4 years ago

vsouvan commented 4 years ago

When doing make install. The cgi binaries and scripts installation should be an optional feature for on demand installation only, that can be enabled using configure and not installed by default.


Imported from Launchpad using lp2gh.

vsouvan commented 4 years ago

(by chris-beauregard) I think I commented on this problem in my commit... the real problem is that we have just one monolithic package which contains the whole thing, and that's not really good Debian practice. If we followed Debian SOP, we'd really be creating multiple packages containing different components. Something like:

libecbufr - just the libecbufr.so and links libecbufr-dev - header files, libtool .la, static lib, example source code libecbufr-tools - bufr_encoder and bufr_decoder libecbufr-data - BUFR tables libecbufr-doc - all the documentation

and, directly relevant to this bug,

libecbufr-cgi - all that CGI stuff

vsouvan commented 4 years ago

(by yves-pelletier) I would support this. Should we make a blueprint of it (although we already have a relevant blueprint about improving debian-conformance)

vsouvan commented 4 years ago

(by vanh-souvanlasy) A new option "-enable-cgi" can be added to configure simply by changing configure.in with "AC_ENABLE_ARG()" and using AC_SUBST() to modify Makefile.am to include or exclude cgi from SUBDIRS build list. The following patch file shows how this works.

vsouvan commented 4 years ago

(by michel-vaneeckhout) Separating the packages according to Debian rules is very good when making debian packages, but when compiling the library for a system not based on the debian packaging system, it would not solve the problem of a broken "make install" for all non-root users. I think for all such systems, the "-enable-cgi" solution is a good one since it lets you compile and install the library on any linux systems without needing a particular packaging system. We should not restrict our installations to debian based systems.

vsouvan commented 4 years ago

(by vanh-souvanlasy) "--enable-cgi" added to trunk and merged into 0.8.2 branch