search

ECCC-MSC / msc-pygeoapi

MSC OGC API pygeoapi deployment
MIT License
16 stars 25 forks source link

Link to Collections in two different sections #12

Closed tomkralidis closed 4 years ago

tomkralidis commented 4 years ago

In GitLab by @alexandreleroux on Aug 23, 2019, 12:03

On https://geo.weather.gc.ca/geomet/features/ we have links to 'Collections' in (A) the Collections section for the HTML version and (B) in the Links section for the JSON version.

What about changing this for those two links to show up in the Collections section only:

This would be consistent with how links in the Links section are currently presented, which is:

Thoughts / comments Tom? cc @rousseaulambertlp

tomkralidis commented 4 years ago

In GitLab by @alexandreleroux on Aug 23, 2019, 13:07

The exact same logic also applies to conformance, which currently is in the Conformance section for HTML and the Links section for JSON.

tomkralidis commented 4 years ago

In GitLab by @tomkralidis on Sep 4, 2019, 13:29

In OGC API - Features we have a links object when processing a root page, so all pygeoapi is doing here is displaying all the links in the equivalent JSON response.

For the collections section of the HTML, we have the single HTML link given the user (browser) is asking for HTML. The JSON link at the top right of the page is the canonical way to see a given page's JSON equivalent.

tomkralidis commented 4 years ago

In GitLab by @alexandreleroux on Sep 19, 2019, 16:17

What annoys me is the two last links at the bottom of https://geo.weather.gc.ca/geomet/features/ , specifically

which not only looks weird given they don't show the same pattern than the 4 links directly above in the same section, but what's weirder to me is that we have conformance/collection links in two different sections of the page instead of the same section! Not consistent with the document/OpenAPI links. We can have a quick phone chat if you think it'll be easier for me to explain what I mean :-) Thanks!

tomkralidis commented 4 years ago

In GitLab by @alexandreleroux on Sep 23, 2019, 08:55

Thanks to @tomkralidis for fixing it at the source: https://github.com/geopython/pygeoapi/pull/245 Closing ticket.

tomkralidis commented 4 years ago

In GitLab by @alexandreleroux on Sep 23, 2019, 08:55

closed