Missing / in link to 'This document as JSON'?

[tomkralidis]

In GitLab by @alexandreleroux on Sep 19, 2019, 16:10

Potential minor issue.

On https://geo.weather.gc.ca/geomet/features/ , all the URLs in the Links section have / in their pattern, except for This document as JSON.

Examples:

• This document as JSON: https://geo.weather.gc.ca/geomet/features?f=json => no / after features
• This document as HTML: https://geo.weather.gc.ca/geomet/features/?f=html => with / after features
• The OpenAPI definition as JSON: https://geo.weather.gc.ca/geomet/features/api?f=json => with / after features
• The OpenAPI definition as HTML: https://geo.weather.gc.ca/geomet/features/api?f=html => with / after features

Is this a minor defect?

[tomkralidis]

In GitLab by @tomkralidis on Sep 19, 2019, 18:24

Thanks @alexandreleroux. For the OpenAPI defs the / is required given the endpoint is /api. I've updated the 'This document as HTML' link to strip the trailing slash in https://github.com/geopython/pygeoapi/commit/3b595958644faa06d751182bb30f088b6f1eb859 for consistency.

Is this a defect? Depends who you ask. Apache has functionality for covering both scenarios as the same.

In theory the URLs are different. On the other hand, the URLs are valid in the sense that the URLs in the Links sections do not need to be equal.

[tomkralidis]

In GitLab by @alexandreleroux on Sep 20, 2019, 08:57

Thanks, I get it, for consistency, it needed to be deleted, which you did. Thanks for the improvement! Closing :-)

[tomkralidis]

In GitLab by @alexandreleroux on Sep 20, 2019, 08:57

closed