ECHibiki / Kissu-Vi

Kissu's post, image+db and API server. sister repo https://github.com/ECHibiki/Kissu-React Parent https://github.com/ECHibiki/Kissu used on https://original.kissu.moe
https://kissu.moe
Other
6 stars 1 forks source link

PHP7.4 - agg's inserter #86

Closed ECHibiki closed 4 years ago

ECHibiki commented 4 years ago

agg Inserter puts none values without quotes for width and height

"width": None, "height":None, should be "width": "None", "height":"None",

a hacky solution is in place, but this could be removed if the updater is updated

if (isset($post['files']) && $post['files']) {
    $post['files'] = str_replace('"width": None', '"width": 0', $post['files']);
    $post['files'] = str_replace('"height":None', '"height": 0', $post['files']);
    $files = json_decode($post['files']);

but a better one might be helpful

ECHibiki commented 4 years ago

Not a bug with viqa but this is an optimization that requires fixing a dependency I don't check and is pretty non-vital

ECHibiki commented 4 years ago

dropped feature