search

ECLaboratorio / BubbleShowCase-Android

BubbleShowCase is a framework that let you to use informative bubbles to help your users pointing out different App features.
MIT License
603 stars 90 forks source link

Add title and desc methods which take a String Res #10

Closed wezley98 closed 6 years ago

wezley98 commented 6 years ago

Since you already have a ref to activity we probably shouldn't need to call:

.title(getString(R.string.showcase_fab_title)

or .description(getString(R.string.showcase_fab_desc))

If we can just pass in string resource, and getstring was called in new desc and title methods?

wezley98 commented 6 years ago

Probably should be same for colors as well:

.backgroundColor(ContextCompat.getColor(requireContext(), R.color.colorAccent))

to:

.backgroundColor(R.color.colorAccent)

JorgeCM commented 6 years ago

Hi wezley98,

Yes, you are right! A new version has been published, and it has been added this option. You have to call "backgroundColorResourceId" and "imageResourceId" and pass the resource ids.

implementation 'com.elconfidencial.bubbleshowcase:bubbleshowcase:LATEST_VERSION'