search

ECMWFCode4Earth / ml_drought

Machine learning to better predict and understand drought. Moving github.com/ml-clim
https://ml-clim.github.io/drought-prediction/
90 stars 18 forks source link

Review - BEFORE/AFTER preprocess #107

Open shaunharrigan opened 5 years ago

shaunharrigan commented 5 years ago

Hi @tommylees112 and @gabrieltseng,

The plot generated using 'before.VHI.plot()' looks obviously incorrect. If you run the AFTER preprocess, does this then fix the peculiar x/y axes (HEIGHT/WIDTH)? If so perhaps it would be worth showing the corrected map too? Or perhaps I've misunderstood the BEFORE/AFTER preprocess?!

PS I can't add the "review" label as I'm not a contributor.

tommylees112 commented 5 years ago

Hi Shaun! Thanks for your review question.

Yes the VHIPreprocessor fixes all of the peculiarities from the VHI dataset. It was one of the more involved preprocessors and required a) changing HEIGHT/WIDTH dimensions into lat and lon, assigning a time dimension from the filename and then regridding/selecting the region of interest as with other Preprocessors.

I think that's what you were referring to? Let me know if I misunderstood!