ECMWFCode4Earth / vAirify

code repository for 2024 Code for Earth project #16
0 stars 0 forks source link

Add site header and breadcrumb nav #102

Closed amehta-scottlogic closed 2 weeks ago

amehta-scottlogic commented 2 weeks ago

Changes

https://github.com/ECMWFCode4Earth/vAirify/assets/110030119/0d0bed76-2d70-4781-86d0-e4f8b07ce57d

Accessibility

We got a couple things flagged but I don't think the tool is working properly.

This is the tool erroring when it tries to figure out contrast issues - can't see any with what we have honestly. image

This one is saying that we have an invalid ARIA role but it isn't as far as I can tell: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/toolbar_role

image

github-actions[bot] commented 2 weeks ago

Coverage report for air-quality-ui

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements 98.05% 151/154
🟒 Branches
95.65% (+2.8% πŸ”Ό)
44/46
🟒 Functions
92.31% (+3.02% πŸ”Ό)
36/39
🟒 Lines 97.84% 136/139
Show new covered files 🐣 |
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :---------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------- | :--------- | :------- | :-------- | :---- | | 🟒 |
`...` / Breadcrumbs.tsx
| 100% | 100% | 100% | 100% | | 🟒 | routes.ts | 100% | 100% | 100% | 100% | | 🟒 |
`...` / Toolbar.tsx
| 100% | 100% | 100% | 100% | | 🟒 |
`...` / Header.tsx
| 100% | 100% | 100% | 100% |

Test suite run success

36 tests passing in 11 suites.

Report generated by πŸ§ͺjest coverage report action from 780b0868b10df319fdd73ea38f4b7d66ae771174

github-actions[bot] commented 2 weeks ago

β˜‚οΈ Python Coverage

current status: βœ…

Overall Coverage

Lines Covered Coverage Threshold Status
752 707 94% 80% 🟒

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 780b086 by action🐍