ECMWFCode4Earth / vAirify

code repository for 2024 Code for Earth project #16
http://136.156.139.13
MIT License
4 stars 1 forks source link

[UI] As a user I want the ability to view the CityPage UI on screen sizes smaller than 1920x1080 #230

Closed mnyamunda-scottlogic closed 2 months ago

mnyamunda-scottlogic commented 3 months ago

Currently when the screen sizing is changed. The leftmost graphs become hidden and cannot be scrolled to. Elements are only fully displayed at 1920x1080

Acceptance criteria

Test Checklist:

Ben-EJ commented 3 months ago

Test Analysis

mwalker-scottlogic commented 3 months ago

Backend tests - PASSED ✅

Image

Frontend tests - 33 Failed, all to do with snapshots

Image

AQI graph snapshot is failing because the line has changed

Image

Pollutant graphs are failing as expecting dimensions 600 x 400 but getting 601 x 400

Image

No2 is correct dimensions but 192 pixels (ratio 0.01 of all image pixels) are different.

Image

note: webkit tests are expecting and getting a different size: Expected an image 1200px by 800px, received 1202px by 800px

mwalker-scottlogic commented 3 months ago

Regression Tests Passed ✅

Image

Frontend system tests

Image

Playwright Regression 25.07.24.pdf

mwalker-scottlogic commented 2 months ago

Regression - PASSED

Image

Playwright Regression 29.07.24.pdf

Image

mnyamunda-scottlogic commented 2 months ago

[celebrate] Max Nyamunda reacted to your message:


From: mwalker-scottlogic @.> Sent: Monday, July 29, 2024 3:04:39 PM To: ECMWFCode4Earth/vAirify @.> Cc: Max Nyamunda @.>; Author @.> Subject: Re: [ECMWFCode4Earth/vAirify] [UI] As a user I want the ability to view the CityPage UI on screen sizes smaller than 1920x1080 (Issue #230)

Regression - PASSED

image.png (view on web)https://github.com/user-attachments/assets/9ba190c7-0d77-4a4d-97b2-5c74c176c4f4

Playwright Regression 29.07.24.pdfhttps://github.com/user-attachments/files/16415142/Playwright.Regression.29.07.24.pdf

image.png (view on web)https://github.com/user-attachments/assets/b8e591ec-c5ba-4d28-8f49-93b82a2c05ba

— Reply to this email directly, view it on GitHubhttps://github.com/ECMWFCode4Earth/vAirify/issues/230#issuecomment-2256189255, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BB4X4MDBUZBPAIAFKQ62FOTZOZKYPAVCNFSM6AAAAABLH63MFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGE4DSMRVGU. You are receiving this because you authored the thread.Message ID: @.***>

The contents of this email and any attachments are intended solely for the addressee and may contain confidential or legally privileged information. If you have received this message in error, please send it back to us, and immediately and permanently delete it. The information may not be used or disclosed except for the purpose for which it has been sent.

Email is susceptible to data corruption, interception, unauthorised amendment, viruses, and unforeseen delays. Although Scott Logic Limited has taken reasonable precautions to avoid these situations, it cannot accept responsibility for any loss or damage sustained as a result of any of these actions and the recipient must ensure that the email (and attachments) are virus-free.

Please note, that we do not accept notification of changes to bank account details by email. This applies to notifications from or to us.

Scott Logic Limited is a limited company registered in England and Wales with registration number 05377430. Registered office address: 6th Floor, The Lumen, St James Boulevard, Newcastle Helix, Newcastle upon Tyne, NE4 5BZ . Our VAT number is 866 1051 30.